Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix synchronizer (grandpa) #1635

Merged
merged 1 commit into from
May 30, 2023
Merged

fix synchronizer (grandpa) #1635

merged 1 commit into from
May 30, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • fix outcome check (syncByBlockInfo returned immediately)
  • fix comparison sign (syncByBlockInfo returned error)
  • fix known_blocks_ removed too early (notifySubscribers was not called)
  • remove duplicate notifySubscribers

Benefits

  • fix some cases of grandpa

Possible Drawbacks

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan enabled auto-merge (squash) May 30, 2023 12:16
@turuslan turuslan merged commit ff56b74 into master May 30, 2023
@turuslan turuslan deleted the fix/grandpa-synchronizer branch May 30, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants