Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prevote precommit #1642

Merged
merged 4 commits into from
Jun 2, 2023
Merged

fix prevote precommit #1642

merged 4 commits into from
Jun 2, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • Fix prevotes were not send in reply to neighbor message
  • Don't precommit until receiving sufficient prevotes

Benefits

  • Finalization works

Possible Drawbacks

  • StreamEngine missing message queue and GrandpaProtocol's initial neighbor message may prevent sending prevote

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@iceseer iceseer self-requested a review June 1, 2023 13:34
@turuslan turuslan enabled auto-merge (squash) June 2, 2023 02:45
@turuslan turuslan merged commit 50f7b1d into master Jun 2, 2023
@turuslan turuslan deleted the fix/grandpa-prevote-precommit branch June 2, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants