Fix incorrect parsing of optional JSON RPC params #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
approved these changes
Jul 31, 2023
igor-egorov
approved these changes
Jul 31, 2023
Harrm
added a commit
that referenced
this pull request
Aug 29, 2023
Co-authored-by: Igor Egorov <igor@soramitsu.co.jp>
Harrm
added a commit
that referenced
this pull request
Aug 29, 2023
Co-authored-by: Igor Egorov <igor@soramitsu.co.jp>
Harrm
added a commit
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
closes #1689
Description of the Change
None params were regarded as an error in some places, where the parameter is optional, and thus can be None.
Benefits
Kagome processes such requests correctly.
Possible Drawbacks
None expected.