Temporary fix for binaryen memory #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
approved these changes
Aug 18, 2023
turuslan
approved these changes
Aug 18, 2023
Whitespace discrepancies found in memory_impl.cpp file were fixed to maintain code consistency and readability. Unnecessary whitespace after comments and function calls were removed, which does not impact functionality but syncs with established coding conventions."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Force resize memory to initial size so that it hopefully doesn't get resized past binaryen's limits.
Temporary fix for #1714
Benefits
Kagome stops crashing at binaryen assert.
Possible Drawbacks
It's a crutch.