Improve error handling in babe_config_repository_impl #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures errors in babe_api_->next_epoch are handled gracefully. Instead of using OUTCOME_TRY that could potentially terminate the process on failure, the new code checks if the 'next_epoch' method call was successful and only then proceeds with calculations. This aims to increase code's reliability by avoiding unexpected crashes in case of unsuccessful 'next_epoch' call.
turuslan
approved these changes
Aug 22, 2023
xDimon
approved these changes
Aug 22, 2023
Co-authored-by: Dmitriy Khaustov <khaustov.dm@gmail.com>
Harrm
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Improve error handling in babe_config_repository_impl This change ensures errors in babe_api_->next_epoch are handled gracefully. Instead of using OUTCOME_TRY that could potentially terminate the process on failure, the new code checks if the 'next_epoch' method call was successful and only then proceeds with calculations. This aims to increase code's reliability by avoiding unexpected crashes in case of unsuccessful 'next_epoch' call. * Update core/consensus/babe/impl/babe_config_repository_impl.cpp Co-authored-by: Dmitriy Khaustov <khaustov.dm@gmail.com> * clang-format --------- Co-authored-by: Dmitriy Khaustov <khaustov.dm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures errors in babe_api_->next_epoch are handled gracefully. Instead of using OUTCOME_TRY that could potentially terminate the process on failure, the new code checks if the 'next_epoch' method call was successful and only then proceeds with calculations. This aims to increase code's reliability by avoiding unexpected crashes in case of unsuccessful 'next_epoch' call.
Referenced issues
None
Description of the Change
Handle error of babe next epoch properly
Benefits
Sync of Kusama from scratch works again
Possible Drawbacks
None