Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: block tree (simple) #1839

Merged
merged 36 commits into from
Oct 10, 2023
Merged

refactor: block tree (simple) #1839

merged 36 commits into from
Oct 10, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • (simple commits)
  • removeUnfinalized (after state sync)
  • weight without approval
  • cache weight
  • remove meta
  • check parent weak_ptr
  • simplify NodeTree and CachedTree usage

Benefits

  • simplify and remove unused.

Possible Drawbacks

turuslan added 30 commits October 9, 2023 13:00
@turuslan
explicit type
e3c77dd 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
root constructor
802c67e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
warp mutex
4977a4f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove unfinalized
b57405c 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove unused
80fbae4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
finalized has_justification
726aaeb 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
unused
f351cbb 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
block weight
b24810b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix test
19cd0ea 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
constructor
07df715 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
meta finalized
8431645 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
meta best
3b89aee 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
meta leaf count
e43f846 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
meta leaf hashes
8796ad0 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
reuse
a38ecd5 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
reuse
6364ec3 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
meta is leaf
4b130ab 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
cmp
5995ba9 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
can descend
8f60064 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
best with
0289def 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove leaf
b1b99a8 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove meta
091ff94 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
weak ptr
90a4e7e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
can descend
50eb803 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
weak parent
55948f7 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
info
db8c353 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
unused
d30fc38 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
find
359ce47 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
no shared
d7f20ed 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
unused
7917b15 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
finalize
f720844 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
finalize justification
6e99885 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from xDimon and kamilsa October 10, 2023 08:50
@turuslan turuslan changed the title refactor: block tree (non-breaking) refactor: block tree (simple) Oct 10, 2023
xDimon
xDimon reviewed Oct 10, 2023
View reviewed changes
core/blockchain/impl/cached_tree.hpp Show resolved Hide resolved
test/core/blockchain/block_tree_test.cpp Show resolved Hide resolved
core/blockchain/impl/cached_tree.cpp Show resolved Hide resolved
core/blockchain/impl/cached_tree.cpp Show resolved Hide resolved
core/blockchain/impl/cached_tree.cpp Show resolved Hide resolved
core/blockchain/impl/block_tree_impl.cpp Outdated Show resolved Hide resolved
@turuslan
remove unfinalized, reorg and prune
525821b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon October 10, 2023 12:25
@turuslan
return info
f20e71d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit f79086d into master Oct 10, 2023
@turuslan turuslan deleted the refactor/block-tree-1 branch October 10, 2023 13:09
@turuslan turuslan mentioned this pull request Oct 11, 2023
Merged
@turuslan turuslan mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @kamilsa