grandpa digest #1854
Merged
grandpa digest #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com> # Conflicts: # core/consensus/grandpa/impl/authority_manager_impl.cpp # core/network/impl/protocols/propagate_transactions_protocol.cpp # test/core/consensus/grandpa/authority_manager_test.cpp
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
kamilsa
approved these changes
Oct 30, 2023
xDimon
approved these changes
Oct 30, 2023
Comment on lines
+102
to
+103
| outcome::result<std::shared_ptr<const primitives::AuthoritySet>> | ||
| AuthorityManagerImpl::authoritiesOutcome(const primitives::BlockInfo &block, |
There was a problem hiding this comment.
Need in-comment explanation (m.b. illustrated) how it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
DigestTrackerandConsistencyKeeperAuthorityManagerImplto useIndexerBenefits
Possible Drawbacks
WarpCache