Refactor: replace Microsoft.GSL #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
turuslan
reviewed
Oct 26, 2023
| namespace kagome::common { | ||
| template <size_t MaxSize> | ||
| class SLBuffer; | ||
| } | ||
|
|
||
| namespace kagome::common { | ||
|
|
||
| class BufferView : public gsl::span<const uint8_t> { | ||
| class BufferView : public std::span<const uint8_t> { |
There was a problem hiding this comment.
Why struct BufferView : span instead of using BufferView = libp2p::BytesIn?
There was a problem hiding this comment.
BufferView is comparable and has additional methods
There was a problem hiding this comment.
span is comparable too (libp2p::BytesIn).
No special methods in BufferView.
toHex and toStringView just call free functions
core/dispute_coordinator/provisioner/impl/prioritized_selection.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
turuslan
approved these changes
Oct 27, 2023
kamilsa
approved these changes
Oct 27, 2023
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Benefits
Possible Drawbacks
Usage Examples or Tests
Alternate Designs