Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove justification requests #1898

Merged
merged 2 commits into from
Dec 12, 2023
Merged

remove justification requests #1898

merged 2 commits into from
Dec 12, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • check before making peer busy (didn't clear busy)
  • remove justification requests
    • syncMissingJustifications busy waiting consumed cpu
    • processBlockAdditionResult requested justifications from all peers
    • grandpa or processBlockAdditionResult don't need requests

Benefits

Possible Drawbacks

  • may request justification for block requested by AuthorityManagerImpl
    • may also try to request periodically assuming grandpa protocol doesn't work

@turuslan
remove justification requests
775ce5d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
xDimon approved these changes Dec 12, 2023
View reviewed changes
core/network/impl/synchronizer_impl.cpp Outdated Show resolved Hide resolved
@turuslan
earlier
e938abd 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit 0bed4b8 into master Dec 12, 2023
10 checks passed
@turuslan turuslan deleted the fix/synchronizer branch December 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilsa kamilsa kamilsa approved these changes

@xDimon xDimon xDimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @kamilsa