Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory check #1911

Merged
merged 8 commits into from
Feb 8, 2024
Merged

memory check #1911

merged 8 commits into from
Feb 8, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Dec 28, 2023 •
edited
Loading

Referenced issues

Description of the Change

  • check wasm memory range.
  • fix offchain randomness.
  • (wasmedge) assert and BOOST_ASSERT don't work.
  • simplify memory.
  • SpanAdl for comparing (<, ==, <=>, ...) std::span.
  • simplify tests.

Benefits

Possible Drawbacks

@turuslan
wasmedge check
2d2e266 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
igor-egorov
igor-egorov approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR will automatically close the referenced issue. Could you please create a separate issue for remaining TODOs?

@turuslan
Copy link
Contributor Author

Merging this PR will automatically close the referenced issue. Could you please create a separate issue for remaining TODOs?

No, it won't, because there are no keywords like resolves/closes

@turuslan
Merge remote-tracking branch 'origin/master' into audit/22-wasmedge
6b1cc66
@turuslan
check memory
693155e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into audit/22-wasmedge
4a9e1e6 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>

# Conflicts:
#	core/runtime/common/memory_allocator.hpp
#	core/runtime/wasm_edge/module_factory_impl.hpp
@turuslan
missing file
921c587 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan changed the title wasmedge check memory check Jan 22, 2024
@turuslan
binaryen
050f0b8 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Harrm
Harrm reviewed Feb 7, 2024
View reviewed changes
core/runtime/wasm_edge/memory_impl.cpp Outdated Show resolved Hide resolved
core/runtime/wasm_edge/memory_impl.hpp Outdated Show resolved Hide resolved
core/common/span_adl.hpp Show resolved Hide resolved
core/runtime/binaryen/runtime_external_interface.hpp Outdated Show resolved Hide resolved
core/runtime/memory.hpp Outdated Show resolved Hide resolved
core/runtime/memory.hpp Outdated Show resolved Hide resolved
core/runtime/common/memory_error.hpp Show resolved Hide resolved
@turuslan
Merge remote-tracking branch 'origin/master' into audit/22-wasmedge
4edc5b9 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>

# Conflicts:
#	core/runtime/wasm_edge/CMakeLists.txt
@turuslan
pr comment
b334573 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from Harrm February 7, 2024 12:50
@turuslan turuslan merged commit aa9c3e9 into master Feb 8, 2024
12 of 13 checks passed
@turuslan turuslan deleted the audit/22-wasmedge branch February 8, 2024 08:35
kamilsa added a commit that referenced this pull request Feb 18, 2024
@kamilsa
Revert "memory check (#1911)"
01c838a 
This reverts commit aa9c3e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-egorov igor-egorov igor-egorov approved these changes

@Harrm Harrm Harrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @Harrm @igor-egorov