Keccak ordered root #1926
Merged
Keccak ordered root #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
reviewed
Jan 12, 2024
| @@ -30,4 +32,9 @@ namespace kagome::common { | |||
| void raise(const T &t) { | |||
| boost::throw_exception(std::system_error(t.value(), t.category())); | |||
| } | |||
|
|
|||
| template<typename T, typename E> | |||
| void raise_on_err(const outcome::result<T, E>& res) { | |||
There was a problem hiding this comment.
outcome.value() throws and returns value.
… into feature/keccak-ordered-root
kamilsa
approved these changes
Jan 15, 2024
turuslan
approved these changes
Jan 15, 2024
… into feature/keccak-ordered-root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
closes #1920
Description of the Change
Make ordered trie root hash function accept a hash function as a parameter. Thusly reuse the code that hashed the trie using blake2b to hash it with keccak.
Benefits
This Host method is required.
Possible Drawbacks
None expected.