Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandersnatch VRF support #1928

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Bandersnatch VRF support #1928

merged 14 commits into from
Jul 17, 2024

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Jan 13, 2024

Referenced issues

Needed as part of sassafras consensus (crypto for ticket, vrf signing/verifyiing)

Description of the Change

Binding bandersnatch-vrf functions

@xDimon xDimon changed the title feature: bandersnatch Bandersnatch VRF support Jan 13, 2024
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise the notes.

CMakeLists.txt Outdated Show resolved Hide resolved
cmake/Hunter/config.cmake Outdated Show resolved Hide resolved
core/crypto/bandersnatch/bandersnatch_provider_impl.cpp Outdated Show resolved Hide resolved
test/core/runtime/wavm/wavm_module_init_test.cpp Outdated Show resolved Hide resolved
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon requested a review from turuslan July 8, 2024 09:27
core/host_api/impl/crypto_extension.cpp Show resolved Hide resolved
core/host_api/impl/crypto_extension.cpp Show resolved Hide resolved
core/host_api/impl/host_api_impl.cpp Show resolved Hide resolved
core/crypto/bandersnatch/vrf.hpp Outdated Show resolved Hide resolved
using RingSignature = common::Blob<BANDERSNATCH_RING_SIGNATURE_SIZE>;
using Signature = common::Blob<BANDERSNATCH_SIGNATURE_SIZE>;

struct VrfInput {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not unique_ptr?
May make template BandersnatchAllocated<T, fn>

core/crypto/bandersnatch/vrf.hpp Outdated Show resolved Hide resolved
core/crypto/bandersnatch/vrf.hpp Outdated Show resolved Hide resolved
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
igor-egorov and others added 5 commits July 10, 2024 20:24
Signed-off-by: Igor Egorov <igor@qdrvm.io>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon enabled auto-merge (squash) July 17, 2024 10:51
@xDimon xDimon merged commit c99ce28 into master Jul 17, 2024
12 of 14 checks passed
@xDimon xDimon deleted the feature/bandersnatch branch July 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants