Implement stack limiter #1946
Merged
Implement stack limiter #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
reviewed
Jan 25, 2024
…feature/stack-limiter
kamilsa
reviewed
Feb 8, 2024
…ure/stack-limiter # Conflicts: # cmake/Hunter/config.cmake # core/parachain/CMakeLists.txt # core/parachain/pvf/pvf_impl.cpp # core/runtime/common/runtime_instances_pool.hpp # test/core/parachain/pvf_test.cpp
|
Macos target currently cannot be built |
igor-egorov
reviewed
Feb 22, 2024
| option(CLEAR_OBJS "Clear object files" OFF) | ||
|
|
||
| if(NOT($ENV{CI}) OR NOT($ENV{GITHUB_ACTIONS})) | ||
| option(TESTING "Build and run test suite" ON) |
turuslan
reviewed
Feb 22, 2024
turuslan
approved these changes
Feb 22, 2024
…ure/stack-limiter
…ure/stack-limiter
…ure/stack-limiter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Audit https://github.com/qdrvm/KAGOME-audit/issues/21
Description of the Change
Instrument the runtime code with a stack limiter to prevent stack overflow attacks. WebAssembly code is analyzed before being compiled, and a deterministic maximum stack depth is calculated for every function. Then, every function call is wrapped with a check that this function call will not exceed the global stack limit when called.
Please also have a look at paritytech/wasm-instrument#86
Benefits
Safer runtime calls.
Possible Drawbacks
Some performance toll.
Usage Examples or Tests
Provided in the code.
Alternate Designs
As we have to be compatible with substrate, hardly any. We could link to the same library the substrate uses.