Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sessions cache #2040

Merged
merged 10 commits into from
May 15, 2024
Merged

Feature/sessions cache #2040

merged 10 commits into from
May 15, 2024

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Apr 12, 2024

Referenced issues

Added session cache to reduce the amount of calculations and kept data for each leaf update.

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@iceseer iceseer marked this pull request as ready for review April 15, 2024 08:24
Signed-off-by: iceseer <iceseer@gmail.com>
1
Signed-off-by: iceseer <iceseer@gmail.com>
2
Signed-off-by: iceseer <iceseer@gmail.com>
3
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
// need to lock removing session infoes
std::vector<
std::shared_ptr<RefCache<SessionIndex, PerSessionState>::RefObj>>
_keeper_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird name

@iceseer iceseer merged commit 3ba5a61 into master May 15, 2024
9 of 10 checks passed
@iceseer iceseer deleted the feature/sessions_cache branch May 15, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants