Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run master TSAN on gcc-12 #2072

Merged
merged 45 commits into from
May 16, 2024
Merged

Run master TSAN on gcc-12 #2072

merged 45 commits into from
May 16, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Apr 30, 2024

Referenced issues

None

Description of the Change

  • Running sanitizers in PRs is now enabled
  • Fixes for sanitizers
  • Update libp2p to 0.1.22
  • Renaming of disable validator mode to --insecure-validator-i-know-what-i-do for consistency with Polkadot-SDK
  • Tests for secure validator mode update

Possible Drawbacks

  • Unfortunately we had to disable landlock test because of issues of executing this test on our CI

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@kamilsa kamilsa marked this pull request as ready for review May 16, 2024 11:17
@kamilsa kamilsa requested review from turuslan and zerg-su May 16, 2024 11:17
@kamilsa kamilsa enabled auto-merge (squash) May 16, 2024 11:17
@@ -82,46 +82,6 @@ jobs:
du -hd1 /__w /github || true

Linux-self-hosted:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that we do not use GitHub runners in the Linux-self-hosted step, df and du are not very relevant for our runners. Additionally, the path /__w /github is also irrelevant. We can delete this steps.

@kamilsa kamilsa force-pushed the update/toolchains-and-runners branch from be6f033 to 2b88a53 Compare May 16, 2024 12:53
@kamilsa kamilsa merged commit d0b94e0 into master May 16, 2024
9 of 12 checks passed
@kamilsa kamilsa deleted the update/toolchains-and-runners branch May 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants