Feature: request chunk protocol v2 #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
…lated data/types Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
…by val_index Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
kamilsa
reviewed
Jul 3, 2024
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
iceseer
approved these changes
Aug 5, 2024
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
kamilsa
approved these changes
Aug 5, 2024
| @@ -97,7 +97,7 @@ namespace kagome::network { | |||
| const std::thread::id this_id_{std::this_thread::get_id()}; | |||
|
|
|||
| void check() const { | |||
| BOOST_ASSERT(this_id_ == std::this_thread::get_id()); | |||
| // BOOST_ASSERT(this_id_ == std::this_thread::get_id()); | |||
There was a problem hiding this comment.
Maybe remove this function?
| cached_.emplace(it->first, result); | ||
|
|
||
| if (result.has_value()) { | ||
| // incFullRecoveriesFinished("unknown", "success"); // TODO fix strategy |
There was a problem hiding this comment.
It will fixed in my next PR (systematic chunks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves partially #2135
Description of the Change
Support req_chunk/2 protocol.
Add/extend needed data structures.
Changed related func signatures.
Add func for computation chunk index from validator index considering provided node features.
REMAINING: need to integrate use function of mapping val_index to chunk_index (provided by PR).
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: