Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix can disconnect #2149

Merged
merged 11 commits into from
Jul 22, 2024
Merged

fix can disconnect #2149

merged 11 commits into from
Jul 22, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Jul 5, 2024 •
edited
Loading

Referenced issues

Description of the Change

  • fix inconsistent PeerState.use_count increment/decrement (caused assert)
    • was incremented when opening stream
    • was decremented when cached session became unused
  • remove PeerState.use_count
    • add separate peer_use_count map, which isn't changed when peers disconnect

Possible Drawbacks

@turuslan
fix can disconnect
89ca24c 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from xDimon and iceseer July 5, 2024 15:09
@turuslan turuslan requested a review from Harrm July 5, 2024 15:25
@kamilsa kamilsa removed the request for review from xDimon July 15, 2024 08:53
@turuslan
cache peer use count
6fd7333 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into fix/peer-use-count
699e708
@turuslan
metric for test
ff212e4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix elliptic
c2d0050 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
not null dangling
2d8d4d8 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
wasm memzero
4cd26aa 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix pvf worker empty code path
019e154 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into fix/peer-use-count
3b30766 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>

# Conflicts:
#	core/parachain/pvf/kagome_pvf_worker_injector.hpp
@turuslan
fix bandersnatch
3a95a8b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Harrm
Harrm reviewed Jul 19, 2024
View reviewed changes
core/runtime/common/module_instance.cpp Outdated Show resolved Hide resolved
core/runtime/common/module_instance.cpp Outdated Show resolved Hide resolved
@turuslan turuslan requested a review from Harrm July 22, 2024 06:33
@turuslan
memset
37fb81d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit af3bc29 into master Jul 22, 2024
12 of 14 checks passed
@turuslan turuslan deleted the fix/peer-use-count branch July 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceseer iceseer iceseer approved these changes

@Harrm Harrm Harrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @Harrm @iceseer