Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grandpa initial round #2157

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix grandpa initial round #2157

merged 2 commits into from
Jul 30, 2024

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • failed to get previous grandpa voters after incomplete warp sync
    • removed dependency on previous grandpa voters
    • removed unnecessary temporary initial round
    • removed voting not working without previous round

Possible Drawbacks

@turuslan
fix grandpa initial round, revert #1903
7b25a91 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@igor-egorov igor-egorov self-requested a review July 23, 2024 08:30
@turuslan turuslan requested a review from xDimon July 23, 2024 08:37
@turuslan turuslan enabled auto-merge (squash) July 30, 2024 05:30
@turuslan turuslan merged commit 1b2c3f8 into master Jul 30, 2024
12 of 14 checks passed
@turuslan turuslan deleted the fix/grandpa-initial-round branch July 30, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grandpa previous round
3 participants
@turuslan @xDimon @igor-egorov