Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grandpa reorg test #2167

Merged
merged 2 commits into from
Aug 5, 2024
Merged

grandpa reorg test #2167

merged 2 commits into from
Aug 5, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Aug 1, 2024 •
edited
Loading

Referenced issues

Description of the Change

  • EnvironmentImpl::bestChainContaining calls BlockTreeImpl::getBestContaining, which doesn't have bug mentioned in issue.
  • add test for getBestContaining when target block not in best chain.
  • fix block tree test was not generating fork blocks

Possible Drawbacks

@turuslan
grandpa reorg test
f5c486f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@kamilsa kamilsa enabled auto-merge (squash) August 5, 2024 11:12
@kamilsa kamilsa merged commit f9754e3 into master Aug 5, 2024
11 checks passed
@kamilsa kamilsa deleted the test/grandpa-reorg branch August 5, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-egorov igor-egorov igor-egorov approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Unit test for ensuring finalization works after reorg
3 participants
@turuslan @kamilsa @igor-egorov