Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing of 0 kind of offchain storage #2191

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Aug 25, 2024

Referenced issues

None

Description of the Change

It turns out

runtime::WasmSpan OffchainExtension::ext_offchain_local_storage_get_version_1(
runtime::WasmI32 kind, runtime::WasmSpan key) {
can actually receive 0 as a storage kind.
This is probably a bug from the runtime. So we should treat this as Persistent storage as it was checked that in Polkadot-SDK the same host api always receives persistent storage kind.
Without this fix KAGOME throws an error

Possible Drawbacks

A bit dirty(

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review August 25, 2024 14:04
@kamilsa kamilsa enabled auto-merge (squash) August 26, 2024 09:36
@kamilsa kamilsa merged commit 565921f into master Aug 26, 2024
13 checks passed
@kamilsa kamilsa deleted the fix/0-kind-storage branch August 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants