Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wasmedge spdlog #2199

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix wasmedge spdlog #2199

merged 3 commits into from
Aug 30, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Aug 30, 2024

Referenced issues

Description of the Change

  • pvf process stdout was spoiled by spdlog
    • change spdlog stdout to stderr

Possible Drawbacks

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from xDimon and Harrm August 30, 2024 08:39
@turuslan turuslan requested review from kamilsa and removed request for xDimon August 30, 2024 09:00
@turuslan turuslan enabled auto-merge (squash) August 30, 2024 10:54
@@ -4,6 +4,8 @@
* SPDX-License-Identifier: Apache-2.0
*/

#include <spdlog/sinks/ansicolor_sink.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please order properly.

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit 2433e35 into master Aug 30, 2024
13 checks passed
@turuslan turuslan deleted the fix/wasmedge-spdlog branch August 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Slow PVF execution in separate process
3 participants