-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nix support #2257
Draft
Lederstrumpf
wants to merge
24
commits into
qdrvm:master
Choose a base branch
from
Lederstrumpf:feature/nix-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/nix support #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except python
need more up to date gcc
Lederstrumpf
force-pushed
the
feature/nix-support
branch
from
November 4, 2024 11:21
c9baa08
to
4a49bab
Compare
This reverts commit bda8f7a.
They should be set on Ubuntu, but not Nix: for Nix, .cargo and .rustup should be within project repo to not pollute system.
Lederstrumpf
force-pushed
the
feature/nix-support
branch
from
November 4, 2024 13:21
fe5f1ce
to
6640b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
WIP implemenation of nix shell/flake to build with nix package manager / NixOS.
Tries to strike a balance between Nix conventions and Kagome's current build workflow.
To test, use
nix-shell shell.nix
ornix develop
.Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: