Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trie values column #2288

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature/trie values column #2288

wants to merge 6 commits into from

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Nov 21, 2024

Referenced issues

Description of the Change

  • Introduce spaced batch to atomically write to several db spaces
  • Put trie values in a separate column from nodes
  • Switch exceptions in state sync flow to outcome::result
  • Remove batchable from generic storage

Possible Drawbacks

  • A migration is required

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review November 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants