Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/scale v2 #2289

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feature/scale v2 #2289

wants to merge 19 commits into from

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Nov 21, 2024

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
1
Signed-off-by: iceseer <iceseer@gmail.com>
3
Signed-off-by: iceseer <iceseer@gmail.com>
3
Signed-off-by: iceseer <iceseer@gmail.com>
4
Signed-off-by: iceseer <iceseer@gmail.com>
4
Signed-off-by: iceseer <iceseer@gmail.com>
4
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer marked this pull request as draft November 21, 2024 13:12
5
Signed-off-by: iceseer <iceseer@gmail.com>
6
Signed-off-by: iceseer <iceseer@gmail.com>
This reverts commit 1c1b74c.
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer marked this pull request as ready for review November 25, 2024 06:16
iceseer and others added 2 commits November 25, 2024 09:20
Signed-off-by: iceseer <iceseer@gmail.com>
s += typeid(a).name();
};
(append(args), ...);
std::cout << "[Inconsistent data]: " << s << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No output is expected to std here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you insist then let's put a clarification:

Suggested change
std::cout << "[Inconsistent data]: " << s << std::endl;
std::cout << "[scale encode inconsistent data]: " << s << std::endl;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to put an assert instead of just printing then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants