Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable UI for Settings to Mods menu and Mods Settings Menu #3

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

ModdingPink
Copy link
Contributor

No description provided.

@qe201020335
Copy link
Owner

Can we not use sirautil by any chance? I don't want to make this simple mod too complex

@ModdingPink
Copy link
Contributor Author

We require SongCore which itself requires SiraUtil, I don't see how it makes a difference

@qe201020335
Copy link
Owner

qe201020335 commented Nov 11, 2024

Oh I did not know that.
I didn't use SiraUtil originally because the mod was basically just a harmony patch, but now it does make sense to use it for the menu logic.

Anyways, thanks a lot for the pr!

@qe201020335 qe201020335 merged commit 2025a57 into qe201020335:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants