Add appengine/v2 memcache support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @faisalraja thanks for this. I'm out of the loop with regards to the current state of App Engine so I have asked for a review by @someone1. I see it's just a bump to using the App Engine v2 API instead of v2 - which is great. |
|
@jongillham Yes, details here. You can now basically use legacy apis on runtime go112+ by adding app_engine_apis: true in your app.yaml and deploying it with gcloud beta app deploy ./app.yaml I have this deployed on one of my production apps. |
|
LGTM! Thank you for the contribution! |
|
@someone1 can you tag this release to v2.0.5? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to use 1st gen memcache on 2nd gen deployments.