fix(log): limit pyad to 0.6.2 for correct log level #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 70.43% 70.43%
=======================================
Files 47 47
Lines 3162 3162
Branches 554 554
=======================================
Hits 2227 2227
Misses 741 741
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. |
Guts
approved these changes
Nov 29, 2024
jmkerloch
force-pushed
the
fix/limit_pyad_for_logs
branch
from
9dd469d
to
bf67a0f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest version 0.36.0 of QDT there are no logs display on Windows.
This comes from an update of python-win-ad to 0.6.3 that cause log level of pyad to be used for all python package.
We limit version of python-win-ad to 0.6.2 to restore log display.
closes #585