Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback resubmission fix #464

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Feedback resubmission fix #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59ac571
Fix requirements
Xpirix Sep 11, 2024
22ab363
Feedback resubmission fix
Xpirix Sep 11, 2024
4955a95
Update unit test
Xpirix Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dockerize/docker/REQUIREMENTS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,4 @@ uwsgi~=2.0
freezegun~=1.4

sentry-sdk~=2.2
setuptools~=74.1
4 changes: 2 additions & 2 deletions qgis-app/plugins/tests/test_plugin_version_feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def test_post_create_single_task_feedback(self):
"feedback": "single line feedback"
}
)
self.assertEqual(response.status_code, 200)
self.assertEqual(response.status_code, 302)
feedbacks = PluginVersionFeedback.objects.filter(
version=self.version_2).all()
self.assertEqual(len(feedbacks), 1)
Expand All @@ -345,7 +345,7 @@ def test_post_create_multiple_task_feedback(self):
"feedback": "- [ ] task one\n - [ ] task two"
}
)
self.assertEqual(response.status_code, 200)
self.assertEqual(response.status_code, 302)
feedbacks = PluginVersionFeedback.objects.filter(
version=self.version_2).all()
self.assertEqual(len(feedbacks), 2)
Expand Down
4 changes: 4 additions & 0 deletions qgis-app/plugins/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,10 @@ def version_feedback(request, package_name, version):
task=task
)
version_feedback_notify(version, request.user)
return HttpResponseRedirect(
reverse('version_feedback',
args=[package_name, version.version])
)
form = VersionFeedbackForm()
feedbacks = PluginVersionFeedback.objects.filter(version=version)
return render(
Expand Down