-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh - add elevation #9612
base: master
Are you sure you want to change the base?
Mesh - add elevation #9612
Conversation
@@ -934,6 +934,15 @@ To add vertices to a mesh layer: | |||
#. Press the |meshDigitizing| :sup:`Digitize mesh elements` button | |||
#. A :guilabel:`Vertex Z value` widget appears on the top right corner of the map canvas. | |||
Set this value to the Z coordinate you would like to assign to the subsequent vertices | |||
#. Choose the method for assigning Z values to new vertices from the drop-down menu in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this behavior interact with https://docs.qgis.org/testing/en/docs/user_manual/working_with_mesh/mesh.html#exploring-the-z-value-assignment-logic?
@JanCaha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces or better enriches the logic described there.
Previously the Z value assignment was driven purely by the the code logic described in that table. Now user has more control over that. He can select from 4 options as described in the PR qgis/QGIS#58877.
The option "Prefer mesh, then Z Widget" would be equal to previous behaviour (described in the linked table).
Would you need more detailed description @DelazJ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply and you somehow confirm my feelings.
This replaces or better enriches the logic described there.
I think we need to review that section and either update the table or clarify its scope. This is also where IMHO the 4 options should first be mentioned (I don't think people will change it during digitizing; it is done as a setting, we'd just remind here that the z is assigned based on the selected rule)
The option "Prefer mesh, then Z Widget" would be equal to previous behaviour (described in the linked table).
Z widget and "advanced digitizing panel z field" still work together? In earlier versions, you could set vertex z value using that.
Also how does it play if I snap to a 3D vector feature? There doesn't seem to be a mention of that in the new options...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Z widget and "advanced digitizing panel z field" still work together? In earlier versions, you could set vertex z value using that.
This should still work the same way it worked previously.
I don't think people will change it during digitizing;
Most likely not, I believe that this will be a preference that will not be changed that often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also how does it play if I snap to a 3D vector feature?
No relation 3D vector features. That might be something to consider in the future, but it is not part of this implementation (was not requested by the funding party).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant, in the past, mesh vertex snapped to a 3D line vector would get Z from that line ( #6883). Was this dropped?Based on their name, I can't find the setting that covers that behavior, now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing was removed. That behavior stayed in.
Previously this behavior was triggered by snapping to the 3D point. The user had no control over that what so ever.
Now this behavior is only triggered if the user selects the Z Widget option from the dropdown menu. The logic is a bit weird (but IMHO it was even before), and maybe the label could be adjusted to reflect that. All other options prefer obtaining Z Value from Mesh or Terrain.
#. Press :guilabel:`Get Z value from project terrain` to set a Z value for selected vertices | ||
from the project terrain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GUI is IMHO misleading (see qgis/QGIS#60512), and this button should be described step 4 or 5 as a way to fill the Z value. Not something you'd do after you applied the transform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that this completely independent step, not related to anything else. It is just a convenient way to assign Z values from specific source to all selected vertices.
Fixes #9463
Goal:
Ticket(s): #