-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server][wmts][fix] updated constant to correct resolution in WMTS tile grid initialization #43418
Conversation
…le grid initialization Constant needed to be updated in order to match the standard rendering pixel size of 0.28mm x 0.28mm defined by the OGC resulting in DPI of 90.71428571429.
…tile_grid_initialization [server][wmts][fix] updated constant to correct resolution in WMTS ti…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @andreassteffens can you also const tileSize ?
Co-authored-by: Alessandro Pasotti <elpaso@itopen.it>
@andreassteffens if you want the three to be closed, the "fix" mention should be added for all, ie |
@andreassteffens can you run the tests and update the WMTS GetCapabilities that failed. |
will take a look at the test case ASAP |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-43418-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 09d2ca8e4f14583a64bd26b9ab05b930ba318fad,94c2194f43cbeef3cea1d56324e0ddf794354b63,63f47db145c1a2c06ca4fd59f321ea5518783bf3,4b4748c7fae108a29b7e6faa21319eb76a08f378,18bbfa9af4eb1a0e8e948f5e641a8d3e56c1a966,b9ab1b701836890708b95dced60e4ae2360cbb11
# Push it to GitHub
git push --set-upstream origin backport-43418-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
Constant needed to be updated in order to match the standard rendering pixel size of 0.28mm x 0.28mm defined by the OGC resulting in DPI of 90.71428571429.
Should fix #34826, fix #42942, fix #39040