Add extent based filtering for SensorThings layers #56564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there's NO way to retrieve the actual data extent using the SensorThings standard, we have to be a bit creative. 1. Initially, the extent is ALWAYS global. This is a worst case scenario, but it means at least that when zooming to the layer that the data will actually be visible (instead of requiring the user to guess where the data is) 2. When retrieving features from the service, we start to build an extent based on their bounding boxes. 3. When we know for certain that we've retrieved all features, we use our calculated actual extent for the layer.
nyalldawson
added
Feature
Needs Documentation
|
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
|
@nyalldawson A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
Allows users to set an extent limit for the layer, so that features are only ever loaded within this extent The extent can be set from the data source manager before adding the layer initially, or modified from the layer properties, source tab.
rouault
reviewed
Mar 3, 2024
python/PyQt6/core/auto_generated/providers/sensorthings/qgssensorthingsutils.sip.in
Show resolved
Hide resolved
rouault
approved these changes
Mar 3, 2024
|
Thanks for the review @rouault ! |
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to set an extent limit for the layer, so that features are only ever loaded within this extent
The extent can be set from the data source manager before adding the layer initially, or modified from the layer properties, source
tab.