Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/plugins: turn on GDAL exceptions to avoid deprecation warning #57477

Merged
merged 6 commits into from
May 22, 2024

Conversation

rouault
Copy link
Contributor

@rouault rouault commented May 17, 2024

Fixes #57344

IHMO not appropriate for backport in stable branches

@github-actions github-actions bot added this to the 3.38.0 milestone May 17, 2024
Copy link

github-actions bot commented May 17, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit c9633b7)

@m-kuhn
Copy link
Member

m-kuhn commented May 19, 2024

This should appear as api break I guess. It will have an implication on some plugins which will be looking for guidance.

@rouault rouault added the API Break! Breaks stable API. Proceed with extreme caution!! label May 19, 2024
@m-kuhn
Copy link
Member

m-kuhn commented May 19, 2024

@rouault
Copy link
Contributor Author

rouault commented May 19, 2024

Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouault
Copy link
Contributor Author

rouault commented May 19, 2024

CC @benoitdm-oslandia FYI, see commit b3a2ac8 where I've tried to correct a test case that you had added in 927a7c1 and that wouldn't work as expected. The OGR SQLite driver refuses to insert PointZ features in a PointZM layer, so I've just reduced the test case to creating an empty layer

doc/api_break.dox Outdated Show resolved Hide resolved
@benoitdm-oslandia
Copy link
Contributor

CC @benoitdm-oslandia FYI, see commit b3a2ac8 where I've tried to correct a test case that you had added in 927a7c1 and that wouldn't work as expected. The OGR SQLite driver refuses to insert PointZ features in a PointZM layer, so I've just reduced the test case to creating an empty layer

Indeed: I should have try to add a feature count test (self.assertTrue(vl.featureCount() > 2) fails) !

I was just trying to test against strange geopackages (bad extent or mismatch geometry type). I had some examples at the moment I wrote the tests but I can not find them anymore.

@nyalldawson nyalldawson merged commit 40b7f13 into qgis:master May 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Break! Breaks stable API. Proceed with extreme caution!!
Projects
None yet
4 participants