-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mvt] implement step expressions + improve conversion of sprites #58233
Conversation
fixes some cases where the sprite was not defined (mainly when data defined) + support step definition
This is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3nids , glad this is being addressed -- only one doc comment.
matchString.join( ',' ), valueString ); | ||
if ( matchString.count() == 1 ) | ||
{ | ||
caseString += QStringLiteral( "WHEN %1 IS %2 THEN %3 " ).arg( attribute, matchString.at( 0 ), valueString ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the optimization.
/** | ||
* Parses and converts a match function value list. | ||
* | ||
* \warning This is private API only, and may change in future QGIS versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we skip \since when it's a private API even though it's exposed to python?
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_38 release-3_38
# Navigate to the new working tree
cd .worktrees/backport-release-3_38
# Create a new branch
git switch --create backport-58233-to-release-3_38
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 0d33487affed2fb952c6ab88bf5bb8b53a1e99cc,9ddd2de832668a5a5e25719bcc70f07f0b1da507,6713b22a9655a73aa32821a2e4513dc1fbccefb7,b66953a0c1aeeab1eaf356a90c4ade8c29f6547e,79e3e48fb9da15d3c251c82b3394d191030b0aca,c93463f91287cea501a3c4f27fbb4abdb6e44e09,3931301c4a87aac5f08579458e7be9a4391ef789,b602cb70fe58f9525539abc37fecbb7a9be0cdae,0fd10899de123717bce75017e8bf3db761d80ee1,165672d823ad52c3c28964a7e9eeb30b2e786f5a,0f762cce15a552ead94ee3ddddcceb54c114daf2
# Push it to GitHub
git push --set-upstream origin backport-58233-to-release-3_38
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_38 Then, create a pull request where the |
this implements step expressions
it also fixes some cases where the sprite was not defined (mainly when data defined) + support step definition
see https://docs.mapbox.com/style-spec/reference/expressions/#step
fixes #57989