main annotation layer should be used as a valid option even if type hint is set to UnknownType (fix #49010) #60341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
added
Processing
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Jan 30, 2025
alexbruy
force-pushed
the
processing-main-annotation-layer
branch
from
c5a17b9 to
c830ee1
Compare
is set to UnknownType (fix qgis#49010)
alexbruy
force-pushed
the
processing-main-annotation-layer
branch
from
a31650e to
32bf17e
Compare
nyalldawson
reviewed
Feb 3, 2025
nyalldawson
reviewed
Feb 4, 2025
nyalldawson
approved these changes
Feb 5, 2025
|
Thank you @alexbruy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If Processing algorithm uses multiple layers parameter with
Qgis::ProcessingSourceType::MapLayertype, annotation layers are should be considered as a valid choice. However, this will fail with the main annotation layer which exists in all projects by default.The
mapLayerFromString()method will returntrueonly if type hint is explicitly set toAnnotation. In case of multiple layers input we check parameter value using theUnknownTypetype hint and main annotation layer won't be considered as a valid parameter value.Fixes #49010.