Revert "Remove dedicated "show editing toolbar" action from 3d windows"

[Withalion]

Fixes #60313
I would like to open discussion on this PR as @uclaros pointed out some eloquent stuff, to which I agree. I would like to come to an agreement with both sides...

The points:

• I don't think the 3d view toolbar is bloated, it only has 12 buttons, which is 44 less than the main windows' default. If you think that's too many, I'd rather remove the semi-broken on-screen navigation relic button instead.
• Point cloud editing might be niche, but the toolbar may accommodate other layer types' editing tools in the future. Vector layer 3d editing is a much requested feature.
• Main window has the editing toolbar visible by default
• Toolbar position and visibility persist in the main window
  But more importantly:
• There is no visible clue that the toolbars are dynamic and one needs to right click. In the main window, toolbars have a handle and are movable. Users (or at least many of them) expect it to be right clickable, and even if not, there is a menu entry to manipulate the toolbars. In the secondary views however, both 2d and 3d, this is not the case.
• Right click does not work on the big blank space to the right of the last item of the main toolbar

[github-actions]

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 6a50a4f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 6a50a4f)

[nyalldawson]

Ok, here's my counter-arguments and resolution proposal:

I don't think the 3d view toolbar is bloated, it only has 12 buttons, which is 44 less than the main windows' default. If you think that's too many,
I'd rather remove the semi-broken on-screen navigation relic button instead.

I would also like to see that removed, but that's a side issue. 😆

Point cloud editing might be niche, but the toolbar may accommodate other layer types' editing tools in the future. Vector layer 3d editing is a much requested feature.

While 11 or 12 actions might not seem like much, it's still UI bloat for a feature which CURRENTLY is of niche use. Sure, there's definitely demand and a LOT more potential users for vector editing in 3d, but we don't have that yet. And when that lands, we'll need to do a comprehensive rework of this 3D editing UI anyway, since the current editing bar is only designed around point cloud editing and won't scale to vector editing well.

Even with #60357 the UX in the editing toolbar is not user friendly. There's no clear indication in the toolbar that the functionality is linked to the main window active layer and there's no clue given as to why only some point cloud layers can be edited and not others. That kind of thing is fine for V1 of a brand new feature, but I also think it's fine for V1 to require users to manually enable this toolbar to get access to these tools.

(I think maybe the point cloud editing action should always be enabled, and a message bar used to give a message when editing can't be toggled for a particular layer -- eg ".ept point cloud layers cannot be edited")

(There's also the issue that the toolbar icon used here is just a reuse of the "add point cloud" layer one, which doesn't give any hint to users that it's got anything to do with editing layers!)

Main window has the editing toolbar visible by default

That's a completely different thing -- it's VECTOR editing, which is a huge component of GIS work. Point cloud editing is not 😄

Toolbar position and visibility persist in the main window

I'm +1 to having the toolbar visibility remembered for the 3d editing toolbar, that's an easy change

But more importantly:

There is no visible clue that the toolbars are dynamic and one needs to right click. In the main window, toolbars have a handle and are movable. Users (or at least many of them) expect it to be right clickable, and even if not, there is a menu entry to manipulate the toolbars. In the secondary views however, both 2d and 3d, this is not the case.
Right click does not work on the big blank space to the right of the last item of the main toolbar

Yep, that's an issue. Maybe we can solve it with an event filter on the toolbar to catch clicks on the unfilled portion of the widget?

Otherwise, how about we bring back the drop down menu for the "settings" action, with entries for "Show Point Cloud Editing Toolbar" and "Options...". That's nice and discoverable, yet doesn't contribute to UI complexity / bloat.

[nyalldawson]

Pinging @nirvn for UI feedback too

[nirvn]

Hey there; some friendly thoughts :)

• I did like the introduction of a right-click menu to enable / disable toolbars, and in the future panels; I felt it was a good way to manage the growth of functionality tied to 3D views. For e.g., we could have the on-screen navigation widget become a panel and also remove that toggle from the toolbar
• We do have a growing number of dialogs that rely on right-click menus to toggle visibility of toolbars and panels (the main window, the layout designer, the georeferencer, the processing modeler, etc.), so I also feel like the move doesn't depart from established UI/UX
• One way to go forward here would be to show the point cloud editing toolbar by default, which will inform user, and have them toggle the toolbar off via right click; alternatively we could throw a one-time message bar telling users to seek additional functionality by right-clicking on the toolbar

The PR opened by @uclaros ( #60357 ) is a nice improvement, and to me just further shouts the need for us to migrate to multiple toolbars in the 3D view panel/dialog the same way we do with other dialogs.

Also, definitively +1 to remembering 3D view toolbar (and panel) visibility across sessions, this is the way 😉