Update conf.in.py #189
Merged
Update conf.in.py #189
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
The build passes regardless of this option, and it will probably be reinstated by sphinx-rtd-theme for self-hosted projects.
|
Well, the display_version option simply returns a warning so let's keep it (and it will probably be reinstated for self-hosted projects -readthedocs/sphinx_rtd_theme#1625). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
October 7th, sphinx-rtd-theme released 3.0.0 version which removes the display_version option from the theme (readthedocs/sphinx_rtd_theme#1598). This PR cleans the conf.py file in order to be compatible with their update (and avoid pinging our theme to 2.0.0 given that we are not hosted by them). Afaics, this implies that we'd lose version mention in the top left corner of the pages
