Migrated to bevy 0.13 and rapier 0.25 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, was in the middle of midterms, taking a look now Thank you for updating |
|
Normally I would prefer people not committing formatting changes too but this one seems somewhat reasonable so it is fine. |
|
Hmm at least on my computer the shadows are really dark in the example world. I'll scan the update notes to see if we are missing something EDIT: bevyengine/bevy#11868 |
qhdwight
approved these changes
Feb 25, 2024
|
Thanks! I did notice the shadows were also darker on my end, but wasn't sure if it was just me. Was my first pull request, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed migration guide. Changed
Input->ButtonInputand KeyCodes start with "Key" now instead of just the letter name.