Skip to content

Conversation

@qiancai
Copy link
Owner

@qiancai qiancai commented Sep 29, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • New Features

    • Added tidb_opt_selectivity_factor system variable (SESSION/GLOBAL, persistent) to control default optimizer selectivity when statistics are unavailable.
    • Introduced per-operator executor concurrency controls (index lookup, index lookup join, hash join, hash aggregation partial/final, projection, window) alongside tidb_executor_concurrency for finer tuning.
  • Documentation

    • Updated system variables reference with details and guidance for the new optimizer selectivity and executor concurrency settings.

@gemini-code-assist
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, according to its title and description, aims to update the system-variables.md documentation to reflect new system variables for controlling optimizer selectivity and per-operator executor concurrency in TiDB. However, the provided patch content only shows the addition of a simple test file, temp.md, which contains 'This is a test file.'. This suggests a potential mismatch between the PR's stated purpose and its current file changes.

Highlights

  • Intended System Variable Additions: The pull request description indicates the addition of a new system variable, tidb_opt_selectivity_factor, designed to control default optimizer selectivity when statistics are unavailable. It also suggests the introduction of per-operator executor concurrency controls for various operations like index lookup, hash join, and aggregation.
  • Intended Documentation Update: The PR's stated purpose, as detailed in the auto-generated summary, is to update the system variables reference documentation with comprehensive details and guidance for the newly introduced optimizer selectivity and executor concurrency settings.
  • Actual Changes in Patch: Despite the stated intent to update system-variables.md, the provided patch content only includes the addition of a new file named temp.md, which contains the text 'This is a test file.'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be incorrect. The title and description suggest an update to the system-variables.md file, but the only change submitted is the addition of temp.md, which seems to be a temporary test file. Please verify that the correct changes have been committed and pushed. The temp.md file should be removed.

@qiancai qiancai closed this Sep 29, 2025
@qiancai qiancai deleted the test-add-a-variable-15 branch September 29, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants