Skip to content

Conversation

@qiancai
Copy link
Owner

@qiancai qiancai commented Sep 29, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • New Features

    • Added tidb_opt_selectivity_factor system variable (SESSION/GLOBAL, persistent) to control default optimizer selectivity when statistics are unavailable.
    • Introduced per-operator executor concurrency controls (index lookup, index lookup join, hash join, hash aggregation partial/final, projection, window) alongside tidb_executor_concurrency for finer tuning.
  • Documentation

    • Updated system variables reference with details and guidance for the new optimizer selectivity and executor concurrency settings.

@gemini-code-assist
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, titled "Update system-variables.md", primarily introduces a new file named "temp.md" with placeholder content. However, the pull request description and an automated summary suggest a broader purpose: to update the TiDB documentation regarding new system variables. Specifically, it aims to document "tidb_opt_selectivity_factor" for controlling optimizer selectivity and introduce details about per-operator executor concurrency controls. It's important to note that the current patch only reflects the addition of "temp.md", not the documentation updates mentioned.

Highlights

  • File Addition: A new file named "temp.md" has been added to the repository, containing the text "This is a test file."
  • Intended Documentation Update: The pull request description and an automated summary indicate an intention to update the "system-variables.md" documentation for TiDB.
  • New System Variables (Intended): The intended documentation update includes details for a new system variable, "tidb_opt_selectivity_factor", which controls default optimizer selectivity, and new per-operator executor concurrency controls (e.g., for index lookup, hash join, projection, window).
  • Discrepancy Noted: There is a discrepancy between the stated intent in the PR description and the actual file changes provided in the patch, which only show the addition of "temp.md" and not the documentation updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request's title and description indicate an update to system-variables.md, but the only change submitted is the addition of a temp.md file with placeholder content. The intended documentation updates appear to be missing from this pull request. Please push the correct changes to resolve this discrepancy.

@qiancai qiancai closed this Sep 29, 2025
@qiancai qiancai deleted the test-add-a-variable-15 branch September 29, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants