-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
103-signup-pages(暂时只能在chrome上,争取后续兼容其它浏览器) #31
Open
jingwang88
wants to merge
15
commits into
qianxueseng-com:fix/dontry
Choose a base branch
from
jingwang88:master
base: fix/dontry
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.将格子变量名更改为有意义的变量名; 2.不再用inline style; 3.不再使用onclick而使用event delegation,原因如下: a.不再需要为每个元素添加时间监听,可以委托给父元素的监听函数来处理; b.可以方便的修改和添加元素,不用因为元素改变而修改事件绑定; c.JavaScript和DOM节点之间的关联变少,这样也就减少了因循环引用而带来的内存泄漏发生的概率。 具体关于Event Delegation可以参考博客http://blog.csdn.net/majian_1987/article/details/8591385
Conflicts: 103-signup-pages/index.js
呼唤 @newraina先code review一遍,然后我再补充 :) |
<a href="https://reg.taobao.com/member/new_register.jhtml?spm=a2145.7268393.0.0.6zw1zj&_lang=zh-S" >中文</a><span>|</span><a href="https://reg.taobao.com/member/new_register.jhtml?spm=a2145.7268393.0.0.6zw1zj&_lang=en&_regfrom=TB_OVERSEA">english</a> | ||
</div> | ||
</div> | ||
<div id="content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个div
标签没有闭合,XHTML不允许省略结束标记 XHTML
我也是初学哈,觉得不对的地方欢迎讨论!:grin: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于还有很多东西不会,做不了102,所以先完成103。
完成以下功能:
1.使用jquery
2.实现淘宝注册页面的第一个页面
3.实现基于正则表达式的手机号码验证,至少11位
4.实现拖住滑块来加入新的验证图片
5.实现点击图片中某个特定区域才能够验证通过
待完成:
1.实现点击可以重新来一张其他的图片
2.实现邮箱注册的页面
3.实现邮箱的正则表达式验证