-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ramsey update #976
base: main
Are you sure you want to change the base?
Fix ramsey update #976
Conversation
The drive frequency is now updated only when a detuning is provided, which is one of the assumption of the fit. When detuning is 0 we update T2 since we expect it to be more reliable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 123 123
Lines 9701 9701
=======================================
Hits 9459 9459
Misses 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In general, it would be better to use In this way, it would be smooth, and working in the same way for a All the behavior currently attributed to |
@@ -295,7 +295,10 @@ def _plot(data: RamseySignalData, target: QubitId, fit: RamseySignalResults = No | |||
|
|||
|
|||
def _update(results: RamseySignalResults, platform: Platform, target: QubitId): | |||
update.drive_frequency(results.frequency[target][0], platform, target) | |||
if int(results.delta_phys[target][0]) == int(results.delta_fitting[target][0]): | |||
update.t2(results.t2[target][0], platform, target) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we log what we are updating in the runcard in case of conditional updates (that depend on fitting)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on the roadmap #910
For the time being I would keep those manipulations directly in the python file where we are handling scripts.
86db54e
to
de9db23
Compare
Thanks @alecandido in the last commits I've changed the default behavior to |
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
The drive frequency is now updated only when a detuning is provided, which is one of the assumption of the fit. When detuning is 0 we update T2 since we expect it to be more reliable.
Now Ramsey can be used to monitor T2 in a more stable way given that the fit will include both oscillations and an exponential decay.
Checklist:
master
main
main