-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute asymmetry in resonator flux fit #978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the resonator flux dependence fit will compute also the asymmetry. It will also update both the matrix element and the sweetspot.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
==========================================
- Coverage 97.50% 97.49% -0.01%
==========================================
Files 123 123
Lines 9722 9734 +12
==========================================
+ Hits 9479 9490 +11
- Misses 243 244 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Edoardo-Pedicillo
approved these changes
Sep 25, 2024
hay-k
reviewed
Oct 7, 2024
src/qibocal/protocols/flux_dependence/resonator_flux_dependence.py
Outdated
Show resolved
Hide resolved
andrea-pasquale
force-pushed
the
improve_resonator_flux
branch
from
October 14, 2024 16:28
b062943
to
2de3b56
Compare
andrea-pasquale
force-pushed
the
improve_resonator_flux
branch
from
October 14, 2024 16:30
2de3b56
to
abcc1d0
Compare
hay-k
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the resonator flux dependence fit will compute also the asymmetry.
It will also update both the matrix element and the sweetspot.
Here is a report: http://login.qrccluster.com:9000/IJapdzbeQUmTfiwfTeKhwQ==/
Checklist:
master
main
main