-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ungroup Z
terms
#125
Ungroup Z
terms
#125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 751 738 -13
=========================================
- Hits 751 738 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@damarkian if you have time this week, could you look through this? Would be good to include it in the next minor release |
Thanks @chmwzc . This is for variable number of shots per observable depending on variance, right? Sorry for troubling you, but could you put the reference here in this PR, for traceability? |
No, I'm still working on that😅 This is for cleaning up the code a bit before I implement other measurement optimization schemes (e.g. the gc_to_qwc branch). |
Alright. One step at a time then. 👌 |
Removes the default grouping of all
Z
terms together when usingexpectation_from_samples
.Will probably add in a flag somewhere to do this optionally after some other measurement optimization schemes have been put in (e.g. the
gc_to_qwc
branch), but the current default is too restrictive.Other changes: