Poetry and workflow changes #29
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Thanks! Just 2 questions/issues:
- Just to confirm, replacing
setup.pywith poetry doesn't affect the current installation instructions (below) right?
git clone https://github.com/qiboteam/qibochem.git
cd qibochem
pip install .
timer.datis a temporary file from runningPSI4, probably created while testing manually? Anyway, it shouldn't be included.
There was a problem hiding this comment.
Thanks! I only have some minor changes to .gitignore.
Other than that, I haven't tried your new installation instructions with poetry yet, but just a thought: the main Qibo repository uses poetry and doesn't need it to install, so we might not need it here? I duno, might look into testing it, after this is merged?
for more information, see https://pre-commit.ci
…ochem into dev/poetry_workflow
I've checked the qibo docs and it says you can just "pip install ." the repo, I've tested it and it works so let me just revert the readme. |
|
I'm writing the sphinx documentation for qibochem, and following a similar format with qibocal. Qibocal documentation mentions that it is essential to install qibolab as both work together. So I'm thinking - will it be easier if we include the psi4 installation separately, as it is part of the conda package management instead of poetry? And I document this in the sphinx doc in a similar way with qibocal? |
environment.yml
Outdated
| @@ -12,5 +12,5 @@ dependencies: | |||
| - pip | |||
| - pip: | |||
| - openfermion>=1.5 | |||
| - qibo | |||
| - pyscf | |||
| - qibo=0.1.10 | |||
There was a problem hiding this comment.
Why the restriction on the Qibo version?
There was a problem hiding this comment.
I agree with @chmwzc let's do what qibotn team did. Also, restriction on Qibo version above has to be >= or ==. But if there is no need for a restriction, it should be removed.
There was a problem hiding this comment.
Should've added a > there, just adding it as a reminder of the lowest working version.
Anyway, I agree with you since this dependency issue is out of the scope of the branch.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage ? 36.19%
=======================================
Files ? 8
Lines ? 442
Branches ? 0
=======================================
Hits ? 160
Misses ? 282
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Added some lines to prevent pytest and pylint from reporting the psi4 import errors, I don't think there's anymore changes to be made on my end if we're pushing off the psi4 dependencies resolution later. Also temporarily disabled sphinx doc checking in the workflow till Adrian finishes his docs, so I'll add that 1 line in when he's done. One small note is that uploading coverage report sometimes fail due to API issues, their end not ours, so you can just retry the workflow till it works if anyone ever experiences that in the future. |
Main changes:
Replace setup.py with poetry and added workflows based on qibo and qibosoq workflows as mentioned previously (#23, #22).
Additionally, resolved 2 dependency issue while fiddling with poetry:
TODO:Missing Psi4 dependencies from poetry messes up the automated workflow, #26holding this off for another branch since the issue is getting in the way of the other changes