Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved expectation function and mic changes #34

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

TL231
Copy link
Contributor

@TL231 TL231 commented Aug 3, 2023

Changed test to work with the move, and updated pyscf version.
Added a .codecov.yml file incase there's any need to change coverage report.
Slight change to the formatting of test.yml to what others used since it was the only one in "" for whatever reason.

@TL231 TL231 requested a review from chmwzc August 3, 2023 01:18
@TL231 TL231 removed the request for review from chmwzc August 3, 2023 01:19
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +1.72% 🎉

Comparison is base (c81b5c5) 36.19% compared to head (8ce7282) 37.92%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   36.19%   37.92%   +1.72%     
==========================================
  Files           8        8              
  Lines         442      443       +1     
==========================================
+ Hits          160      168       +8     
+ Misses        282      275       -7     
Flag Coverage Δ
unittests 37.92% <87.50%> (+1.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/qibochem/driver/molecule.py 49.00% <ø> (-1.25%) ⬇️
src/qibochem/measurement/expectation.py 27.02% <87.50%> (+27.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TL231 TL231 requested a review from chmwzc August 3, 2023 01:29
@TL231
Copy link
Contributor Author

TL231 commented Aug 3, 2023

Side note, code coverage is poor, so I'll write up some simple tests to improve it.

Copy link
Contributor

@chmwzc chmwzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@chmwzc chmwzc merged commit 919c303 into main Aug 3, 2023
@chmwzc chmwzc deleted the dev/expectation_function branch August 3, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants