Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create_dummy from public interface #1154

Open
stavros11 opened this issue Feb 24, 2025 · 0 comments
Open

Remove create_dummy from public interface #1154

stavros11 opened this issue Feb 24, 2025 · 0 comments
Milestone

Comments

@stavros11
Copy link
Member

However, I just noticed create_dummy is not part of the public interface...

It's true that usage in tests is limited
https://github.com/search?q=repo%3Aqiboteam%2Fqibolab+create_dummy+path%3A%2F%5Etests%5C%2F%2F&type=code
and most likely even direct usage outside Qibolab (because create_platform("dummy") is fully equivalent). But it would be breaking.

We may consider deprecating, and maintain a single access point to the dummy platform. But we need to schedule these for 0.3

Originally posted by @alecandido in #1153 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant