Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for create_platform when Hardware is used #1153

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

stavros11
Copy link
Member

Adds test for the fix in #1151.

@stavros11 stavros11 requested a review from alecandido February 23, 2025 16:14
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.69%. Comparing base (e12d6f5) to head (fa1b22e).
Report is 3 commits behind head on hardware-instruments-load.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           hardware-instruments-load    #1153      +/-   ##
=============================================================
+ Coverage                      52.60%   52.69%   +0.09%     
=============================================================
  Files                             71       71              
  Lines                           3173     3177       +4     
=============================================================
+ Hits                            1669     1674       +5     
+ Misses                          1504     1503       -1     
Flag Coverage Δ
unittests 52.69% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions for refinement. But in general it is definitely good. Thanks for the addition!

@stavros11 stavros11 merged commit 872373d into hardware-instruments-load Feb 24, 2025
40 checks passed
@stavros11 stavros11 deleted the test-hardware-instruments-load branch February 24, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants