Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify QM cluster name #1149

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Specify QM cluster name #1149

merged 2 commits into from
Feb 24, 2025

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Feb 17, 2025

Allow specifying the cluster name used in the QuantumMachinesManager to support multiple cluster configurations.

*TII note: This is needed to use qw5q_platinum with the second OPX1000 cluster, which is connected to the same router as the first one.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.56%. Comparing base (b929bac) to head (ef67c2c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/qibolab/_core/instruments/qm/controller.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   52.60%   52.56%   -0.04%     
==========================================
  Files          71       71              
  Lines        3173     3175       +2     
==========================================
  Hits         1669     1669              
- Misses       1504     1506       +2     
Flag Coverage Δ
unittests 52.56% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the mentioned docs, I have nothing to amend. Thanks :)

@stavros11 stavros11 merged commit 00164e3 into main Feb 24, 2025
39 of 40 checks passed
@stavros11 stavros11 deleted the qm-cluster branch February 24, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants