Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for client constructor #122

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Conversation

zhengjian526
Copy link
Collaborator

#119 add test case for client constructor

Copy link

Code Coverage Report
for detail, goto summary download Artifacts

Filename                    Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
client_util.hpp                     3                 1    66.67%          19                 8    57.89%           2                 1    50.00%
codec.h                             3                 0   100.00%          19                 2    89.47%           0                 0         -
connection.h                       34                 8    76.47%         344               123    64.24%          64                39    39.06%
io_service_pool.h                   5                 0   100.00%          32                 1    96.88%          12                 1    91.67%
md5.hpp                            19                 2    89.47%         127                 8    93.70%          24                 0   100.00%
nonstd_any.hpp                     13                10    23.08%          28                22    21.43%           0                 0         -
router.h                            9                 2    77.78%          80                32    60.00%          10                 6    40.00%
rpc_client.hpp                     63                30    52.38%         591               270    54.31%          98                63    35.71%
rpc_server.h                       20                 7    65.00%         156                51    67.31%          32                18    43.75%
string_view.hpp                    17                11    35.29%          38                30    21.05%           2                 2     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             186                71    61.83%        1434               547    61.85%         244               130    46.72%

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3e2746e) 44.02% compared to head (5c22ede) 46.87%.
Report is 1 commits behind head on master.

Files Patch % Lines
tests/test_rest_rpc.cpp 88.88% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   44.02%   46.87%   +2.84%     
==========================================
  Files         168      166       -2     
  Lines        7666     7740      +74     
==========================================
+ Hits         3375     3628     +253     
+ Misses       4291     4112     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qicosmos qicosmos self-requested a review January 24, 2024 09:18
Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit 8863115 into qicosmos:master Jan 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants