Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HACK: Remove vega editor for now #230

Merged
merged 2 commits into from
Jun 2, 2020
Merged

HACK: Remove vega editor for now #230

merged 2 commits into from
Jun 2, 2020

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jun 2, 2020 •
edited
Loading

A temporary band aid for #229

thermokarst
thermokarst suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than editing the vendored vega libraries (at least thats what I am assuming happened in this diff), please modify this bit of the template to stop rendering or remove the vega editor button:

q2-feature-table/q2_feature_table/_summarize/summarize_assets/sample-frequency-detail.html

Lines 78 to 83 in 24553e8

// Clean up the vega-embed toolbar
var toolbar = $("div .vega-actions").detach();
toolbar.addClass("btn-group");
toolbar.children("a").each(function() {
$(this).addClass("btn btn-default");
});

Thanks!

thermokarst
thermokarst suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - can you please undo whatever changed in the vega-embed.min.js file, though? Thanks!

@Oddant1
Copy link
Member Author

Oddant1 commented Jun 2, 2020

Oh what the heck I thought I did

@thermokarst
Copy link
Contributor

Oh weird - maybe my page was cached? I just reloaded and its gone - sorry about that!

@Oddant1
Copy link
Member Author

Oddant1 commented Jun 2, 2020 •
edited
Loading

maybe my page was cached?

That darn internet trolling us as usual

@thermokarst
Copy link
Contributor

Travis is failing due to unrelated whitespace issues - can you please cut a new PR that fixes that? Thanks!

@thermokarst thermokarst merged commit 3e57996 into qiime2:master Jun 2, 2020
@Oddant1
Copy link
Member Author

Oddant1 commented Jun 2, 2020

Travis is failing due to unrelated whitespace issues - can you please cut a new PR that fixes that? Thanks!

Can do

@Oddant1 Oddant1 deleted the remove_summarize_vega_editor branch June 25, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thermokarst thermokarst thermokarst approved these changes

Assignees

@Oddant1 Oddant1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oddant1 @thermokarst